src: revert IS_RELEASE to 0 #49084
src: revert IS_RELEASE to 0 #49084
Conversation
|
Fast-track has been requested by @RafaelGSS. Please 👍 to approve. |
|
This has happened 4 times in the last year alone. Can we correct the documentation or somehow highlight the importance of making sure the flag is set back to 0 after a release? |
|
cc @nodejs/releasers |
We're discussing it on nodejs release channel. Basically, when no conflicts happen when https://github.com/nodejs/node/blob/main/doc/contributing/releases.md#13-cherry-pick-the-release-commit-to-main we should remember to manually revert the flag. We can, possibly, change the command to include a |
|
I'd like to propose that we just land this and don't wait for CI since all the changes are a single bit flip that will itself unbreak CI |
atlowChemi
added
request-ci
|
Landed in 23d65e7 |
PR-URL: nodejs#49084 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
RafaelGSS
added
dont-land-on-v16.x
dont-land-on-v18.x
PR-URL: nodejs#49084 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: nodejs#49084 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
The steps from https://github.com/nodejs/node/blob/main/doc/contributing/releases.md aren't working fine when dealing with multiple releases